close connection when redis returns WRONGPASS
#275
Merged
+74
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdrew
force-pushed
the
wrongpass-close
branch
3 times, most recently
from
4c745b1 to
f20612c
Compare
byroot
reviewed
Dec 20, 2025
| connect_error.set_backtrace(error.backtrace) | ||
| raise connect_error | ||
| rescue CommandError => error | ||
| @raw_connection&.close |
Member
There was a problem hiding this comment.
What I like about closing the connection is that the WRONGPASS and many other errors could be the result of a recent failover or some other issues of the sort, and to recover from it, you may need to redo the DNS resolution.
Hence not only I think closing the connection is better, but I think we should also do it in case of FailoverError.
Contributor
Author
There was a problem hiding this comment.
Should FailoverError be handled differently from CannotConnectError then? I.e. should CannotConnectError also have @raw_connection&.close?
Member
There was a problem hiding this comment.
I think all errors during connect should drop the connection.
Contributor
Author
There was a problem hiding this comment.
Sounds good. I've updated this PR.
nerdrew
force-pushed
the
wrongpass-close
branch
from
1444629 to
1f3ad8c
Compare
byroot
force-pushed
the
wrongpass-close
branch
from
1f3ad8c to
37b7d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.